Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: chrome/browser/history/history_service.h

Issue 865443005: Inline ScheduleAndForget implementation in HistoryService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index bbf4f1b5d1af8fbb4122fe7d2c097a51050fe146..c14dafc4231a1b1fc917df61fe56fc167bde56a1 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -786,85 +786,6 @@ class HistoryService : public syncer::SyncableService,
// Invokes all callback registered by AddFaviconChangedCallback.
void NotifyFaviconChanged(const std::set<GURL>& changed_favicons);
- // ScheduleAndForget ---------------------------------------------------------
- //
- // Functions for scheduling operations on the history thread that do not need
- // any callbacks and are not cancelable.
-
- template<typename BackendFunc>
- void ScheduleAndForget(SchedulePriority priority,
- BackendFunc func) { // Function to call on backend.
- DCHECK(thread_) << "History service being called after cleanup";
- DCHECK(thread_checker_.CalledOnValidThread());
- ScheduleTask(priority, base::Bind(func, history_backend_.get()));
- }
-
- template<typename BackendFunc, typename ArgA>
- void ScheduleAndForget(SchedulePriority priority,
- BackendFunc func, // Function to call on backend.
- const ArgA& a) {
- DCHECK(thread_) << "History service being called after cleanup";
- DCHECK(thread_checker_.CalledOnValidThread());
- ScheduleTask(priority, base::Bind(func, history_backend_.get(), a));
- }
-
- template<typename BackendFunc, typename ArgA, typename ArgB>
- void ScheduleAndForget(SchedulePriority priority,
- BackendFunc func, // Function to call on backend.
- const ArgA& a,
- const ArgB& b) {
- DCHECK(thread_) << "History service being called after cleanup";
- DCHECK(thread_checker_.CalledOnValidThread());
- ScheduleTask(priority, base::Bind(func, history_backend_.get(), a, b));
- }
-
- template<typename BackendFunc, typename ArgA, typename ArgB, typename ArgC>
- void ScheduleAndForget(SchedulePriority priority,
- BackendFunc func, // Function to call on backend.
- const ArgA& a,
- const ArgB& b,
- const ArgC& c) {
- DCHECK(thread_) << "History service being called after cleanup";
- DCHECK(thread_checker_.CalledOnValidThread());
- ScheduleTask(priority, base::Bind(func, history_backend_.get(), a, b, c));
- }
-
- template<typename BackendFunc,
- typename ArgA,
- typename ArgB,
- typename ArgC,
- typename ArgD>
- void ScheduleAndForget(SchedulePriority priority,
- BackendFunc func, // Function to call on backend.
- const ArgA& a,
- const ArgB& b,
- const ArgC& c,
- const ArgD& d) {
- DCHECK(thread_) << "History service being called after cleanup";
- DCHECK(thread_checker_.CalledOnValidThread());
- ScheduleTask(priority, base::Bind(func, history_backend_.get(),
- a, b, c, d));
- }
-
- template<typename BackendFunc,
- typename ArgA,
- typename ArgB,
- typename ArgC,
- typename ArgD,
- typename ArgE>
- void ScheduleAndForget(SchedulePriority priority,
- BackendFunc func, // Function to call on backend.
- const ArgA& a,
- const ArgB& b,
- const ArgC& c,
- const ArgD& d,
- const ArgE& e) {
- DCHECK(thread_) << "History service being called after cleanup";
- DCHECK(thread_checker_.CalledOnValidThread());
- ScheduleTask(priority, base::Bind(func, history_backend_.get(),
- a, b, c, d, e));
- }
-
base::ThreadChecker thread_checker_;
// The thread used by the history service to run complicated operations.

Powered by Google App Engine
This is Rietveld 408576698