Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 865443005: Inline ScheduleAndForget implementation in HistoryService (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
droger
CC:
browser-components-watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline ScheduleAndForget implementation in HistoryService ScheduleAndForget is a thin wrapper around ScheduleTask that hides a base::Bind() call and passing the HistoryBackend pointer as the first parameter. As they are templated function, they prevent splitting HistoryService into a pure virtual interface and a implementation interface that would improve the componentization velocity. BUG=370850 R=droger@chromium.org Committed: https://crrev.com/f2cd18db42d5ce1404deba163ffdec0fb00f0fad Cr-Commit-Position: refs/heads/master@{#314006}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed DCHECK back to CHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -127 lines) Patch
M chrome/browser/history/android/android_history_provider_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 chunk +0 lines, -79 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 17 chunks +71 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sdefresne
5 years, 10 months ago (2015-01-30 16:07:52 UTC) #1
droger
LGTM, but I am not familiar enough with the code to know if the CHECK ...
5 years, 10 months ago (2015-01-30 16:40:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865443005/20001
5 years, 10 months ago (2015-01-30 20:46:52 UTC) #4
sdefresne
https://codereview.chromium.org/865443005/diff/1/chrome/browser/history/history_service.cc File chrome/browser/history/history_service.cc (right): https://codereview.chromium.org/865443005/diff/1/chrome/browser/history/history_service.cc#newcode1027 chrome/browser/history/history_service.cc:1027: DCHECK(thread_) << "History service being called after cleanup"; On ...
5 years, 10 months ago (2015-01-30 21:17:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 22:14:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 22:15:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2cd18db42d5ce1404deba163ffdec0fb00f0fad
Cr-Commit-Position: refs/heads/master@{#314006}

Powered by Google App Engine
This is Rietveld 408576698