Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 865423002: Revert of Remove the use of page id from determining whether to send the initial document notification. (Closed)

Created:
5 years, 11 months ago by kochi
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the use of page id from determining whether to send the initial document notification. (patchset #3 id:40001 of https://codereview.chromium.org/853693003/) Reason for revert: The series of changes (r312793, r312792, r312791) are suspected to break pushState() related layout tests in Blink. Might be some of them only affected, but let me revert all of them. BUG=451351 Original issue's description: > Remove the use of page id from determining whether to send the initial document notification. > > BUG=369661 > TEST=tests stay green > > Committed: https://crrev.com/4442a6507d04b27eea65065c3a849f3c9d570352 > Cr-Commit-Position: refs/heads/master@{#312793} TBR=creis@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/a4758bcdbf0cf027f18e3e87f15de51ce757eee0 Cr-Commit-Position: refs/heads/master@{#312801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kochi
5 years, 11 months ago (2015-01-23 09:25:09 UTC) #1
Created Revert of Remove the use of page id from determining whether to send the
initial document notification.

Powered by Google App Engine
This is Rietveld 408576698