Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 865393004: [turbofan] Move GetCommonDominator to BasicBlock. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move GetCommonDominator to BasicBlock. Also add some unittests for the dominator stuff. R=mstarzinger@chromium.org Committed: https://crrev.com/cd2bc96808241f0f0382fdefdaa33e4cf6bf2d75 Cr-Commit-Position: refs/heads/master@{#26241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -24 lines) Patch
M src/compiler/schedule.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/schedule.cc View 2 chunks +18 lines, -5 lines 0 comments Download
M src/compiler/scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/scheduler.cc View 5 chunks +4 lines, -18 lines 0 comments Download
M test/unittests/compiler/schedule-unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-23 09:20:56 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-23 09:21:29 UTC) #2
Michael Starzinger
LGTM.
5 years, 11 months ago (2015-01-23 09:25:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865393004/1
5 years, 11 months ago (2015-01-23 09:26:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 09:55:40 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 09:55:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd2bc96808241f0f0382fdefdaa33e4cf6bf2d75
Cr-Commit-Position: refs/heads/master@{#26241}

Powered by Google App Engine
This is Rietveld 408576698