Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 865373002: Removed calls to [HyperlinkTextView setMessageAndLink:withLink:...] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor change to address merge conflict Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
index 9651817b430394de539299e78ce83bf4766a0cbb..aeb3fac0cc02b6c819b345a72b8e8f2160b4e9a5 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
@@ -444,15 +444,14 @@ class ExtensionLoadedNotificationObserver
IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK));
NSString* message(l10n_util::GetNSStringWithFixup(
IDS_EXTENSION_INSTALLED_SIGNIN_PROMO));
+ message = [link stringByAppendingString:message];
HyperlinkTextView* view = promo_.get();
- [view setMessageAndLink:message
- withLink:link
- atOffset:0
- font:font
- messageColor:[NSColor blackColor]
- linkColor:gfx::SkColorToCalibratedNSColor(
- chrome_style::GetLinkColor())];
+ [view setMessage:message withFont:font messageColor:[NSColor blackColor]];
+ [view addLinkRange:NSMakeRange(0, [link length])
+ withName:@""
+ linkColor:gfx::SkColorToCalibratedNSColor(
+ chrome_style::GetLinkColor())];
// HACK! The TextView does not report correct height even after you stuff
// it with text (it tells you it is single-line even if it is multiline), so
« no previous file with comments | « chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698