chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 865373002: Removed calls to [HyperlinkTextView setMessageAndLink:withLink:...]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 865373002: Removed calls to [HyperlinkTextView setMessageAndLink:withLink:...] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary check, changed formatting Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm ('K') | « chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 9651817b430394de539299e78ce83bf4766a0cbb..aeb3fac0cc02b6c819b345a72b8e8f2160b4e9a5 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -444,15 +444,14 @@ class ExtensionLoadedNotificationObserver

IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK));

NSString* message(l10n_util::GetNSStringWithFixup(

IDS_EXTENSION_INSTALLED_SIGNIN_PROMO));

+ message = [link stringByAppendingString:message];

HyperlinkTextView* view = promo_.get();

- [view setMessageAndLink:message

- withLink:link

- atOffset:0

- font:font

- messageColor:[NSColor blackColor]

- linkColor:gfx::SkColorToCalibratedNSColor(

- chrome_style::GetLinkColor())];

+ [view setMessage:message withFont:font messageColor:[NSColor blackColor]];

+ [view addLinkRange:NSMakeRange(0, [link length])

+ withName:@""

+ linkColor:gfx::SkColorToCalibratedNSColor(

+ chrome_style::GetLinkColor())];

// HACK! The TextView does not report correct height even after you stuff

// it with text (it tells you it is single-line even if it is multiline), so