Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

Issue 865373002: Removed calls to [HyperlinkTextView setMessageAndLink:withLink:...] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unnecessary check, changed formatting Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm
index d6c0de1689d19206affeb70769be10d861a2380a..079351758520971b4b30f58c0fed636d9548678d 100644
--- a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm
+++ b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm
@@ -213,34 +213,36 @@ const float kHideDuration = 0.7;
[exitLabel_.get() setDelegate:self];
NSString* exitLinkText;
- NSString* exitUnlinkedText;
+ NSString* exitLinkedText;
if (bubbleType_ ==
EXCLUSIVE_ACCESS_BUBBLE_TYPE_FULLSCREEN_MOUSELOCK_EXIT_INSTRUCTION ||
bubbleType_ == EXCLUSIVE_ACCESS_BUBBLE_TYPE_MOUSELOCK_EXIT_INSTRUCTION) {
exitLinkText = @"";
- exitUnlinkedText =
+ exitLinkedText =
[@" " stringByAppendingString:l10n_util::GetNSStringF(
IDS_FULLSCREEN_PRESS_ESC_TO_EXIT,
l10n_util::GetStringUTF16(
IDS_APP_ESC_KEY))];
} else {
exitLinkText = l10n_util::GetNSString(IDS_EXIT_FULLSCREEN_MODE);
- exitUnlinkedText =
- [@" " stringByAppendingString:l10n_util::GetNSStringF(
- IDS_EXIT_FULLSCREEN_MODE_ACCELERATOR,
- l10n_util::GetStringUTF16(
- IDS_APP_ESC_KEY))];
+ NSString* messageText = l10n_util::GetNSStringF(
+ IDS_EXIT_FULLSCREEN_MODE_ACCELERATOR,
+ l10n_util::GetStringUTF16(IDS_APP_ESC_KEY));
+ exitLinkedText = [NSString stringWithFormat:@"%@ %@", exitLinkText,
+ messageText];
Alexei Svitkine (slow) 2015/01/28 14:55:03 Nit: how about this formatting: exitLinkedTex
shrike 2015/01/28 17:35:04 Done.
}
NSFont* font = [NSFont
systemFontOfSize:[NSFont
systemFontSizeForControlSize:NSRegularControlSize]];
- [(HyperlinkTextView*)exitLabel_.get() setMessageAndLink:exitUnlinkedText
- withLink:exitLinkText
- atOffset:0
- font:font
- messageColor:[NSColor blackColor]
- linkColor:[NSColor blueColor]];
+ [exitLabel_.get() setMessage:exitLinkedText
+ withFont:font
+ messageColor:[NSColor blackColor]];
+ if ([exitLinkText length] != 0) {
+ [exitLabel_.get() addLinkRange:NSMakeRange(0, [exitLinkText length])
+ withName:@""
+ linkColor:[NSColor blueColor]];
+ }
[exitLabel_.get() setAlignment:NSRightTextAlignment];
NSRect labelFrame = [exitLabel_ frame];

Powered by Google App Engine
This is Rietveld 408576698