Issue 865333003: Always use the FreeType headers included in PDFium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 865333003: Always use the FreeType headers included in PDFium. (Closed)

Created:
5 years, 10 months ago by jam

Modified:
5 years, 10 months ago

Reviewers:
brettw

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Always use the FreeType headers included in PDFium. The problem with trying to use the system headers sometimes is that we'll need to use pkg-config which is pretty slow. BUG=453844 TBR=brettw Committed: https://pdfium.googlesource.com/pdfium/+/f8af67788cbe2f4b4f40a707e6cdc29a1a2187fb

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	BUILD.gn	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	pdfium.gyp	View		1 chunk	+3 lines, -7 lines	0 comments	Download

Total messages: 3 (1 generated)

jam

5 years, 10 months ago (2015-02-01 19:22:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f8af67788cbe2f4b4f40a707e6cdc29a1a2187fb (presubmit successful).