Update Touch Feedback on Volume tray

Update Touch Feedback on Volume tray

Update the visual feedback for touch on the volume tray.

Increased the touch region for the mute button. Combined the views after the
volume slider into one touch region that opens the detailed view.

Additionally removed subclasses of ui/views/controls/ inside VolumeView, where
update logic was only extension.

Removed need for custom layout by setting up the BoxLayout to tread the slider
as a flex region.

TEST=Manually tested on device
BUG=447213
Committed: https://crrev.com/e5a9eec0d2e9423913f022abc4a120b9085b8fdc
Cr-Commit-Position: refs/heads/master@{#313113}

[jonross, 2015-01-22 22:25:55]

Patchset #1 (id:1) has been deleted

[jonross, 2015-01-22 22:26:45]

jonross@chromium.org changed reviewers:
+ skuhne@chromium.org

[jonross, 2015-01-22 22:26:46]

Hey Stefan,

I've updated how touch feedback works in the volume tray of the system tray.

Could you provide a review?

Thanks,
Jon

[jonross, 2015-01-23 19:39:41]

jonross@chromium.org changed reviewers:
+ tdanderson@chromium.org

[tdanderson, 2015-01-23 20:03:25]

LGTM. My only comments would be to wrap the CL description at 80 characters per
line (makes it easier for others to read when looking through logs) and consider
if there are any useful tests that could be added for this.

[jonross, 2015-01-23 20:08:33]

jonross@chromium.org changed reviewers:
+ sadrul@chromium.org

[jonross, 2015-01-23 20:08:34]

Hi Sadrul,

Could you provide an owners review to my changes in
ash/system/audio/volume_view.(h/cc)?

Thanks,
Jon

[sadrul, 2015-01-26 18:02:55]

LGTM

https://codereview.chromium.org/865333002/diff/20001/ash/system/audio/volume_...
File ash/system/audio/volume_view.cc (right):

https://codereview.chromium.org/865333002/diff/20001/ash/system/audio/volume_...
ash/system/audio/volume_view.cc:154: more_region_->AddChildView(more_);
Have you considered using TrayItemMore instead of managing |more_| etc. here?

[jonross, 2015-01-26 19:19:01]

https://codereview.chromium.org/865333002/diff/20001/ash/system/audio/volume_...
File ash/system/audio/volume_view.cc (right):

https://codereview.chromium.org/865333002/diff/20001/ash/system/audio/volume_...
ash/system/audio/volume_view.cc:154: more_region_->AddChildView(more_);
On 2015/01/26 18:02:55, sadrul wrote:
> Have you considered using TrayItemMore instead of managing |more_| etc. here?

I had considered it, however TrayItemMore is a bit restrictive in what children
it supports. It wouldn't directly support the Slider that this tray item needs.

I wouldn't object to modifying TrayItemMore to be able to do any View in the
middle region, and to support an expanding More region. Then this entire class
could be cleaned up.

[jonross, 2015-01-26 19:19:05]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2015-01-26 19:20:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/865333002/20001

[commit-bot: I haz the power, 2015-01-26 20:19:46]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-01-26 20:21:57]

Patchset 1 (id:??) landed as
https://crrev.com/e5a9eec0d2e9423913f022abc4a120b9085b8fdc
Cr-Commit-Position: refs/heads/master@{#313113}

[Mr4D (OOO till 08-26), 2015-03-25 21:53:37]

Sorry for this far too late review, but I was then travelling in Asia and once I
was back it was apparently submitted.

lgtm