Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2725)

Unified Diff: shell/app_child_process.cc

Issue 865253002: Delete temporary application file as soon as the application is launched. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/app_child_process.cc
diff --git a/shell/app_child_process.cc b/shell/app_child_process.cc
index 3a00843a7aa53f08a708c5a2ec9ac54146b8d2cd..0091bb015a8eb6fc009d56651c608e7768d27c4f 100644
--- a/shell/app_child_process.cc
+++ b/shell/app_child_process.cc
@@ -184,13 +184,16 @@ class AppChildControllerImpl : public InterfaceImpl<AppChildController> {
// |AppChildController| methods:
void StartApp(const String& app_path,
+ uint8_t cleanup_behavior,
ScopedMessagePipeHandle service) override {
DVLOG(2) << "AppChildControllerImpl::StartApp(" << app_path << ", ...)";
DCHECK(thread_checker_.CalledOnValidThread());
- unblocker_.Unblock(base::Bind(&AppChildControllerImpl::StartAppOnMainThread,
- base::FilePath::FromUTF8Unsafe(app_path),
- base::Passed(&service)));
+ unblocker_.Unblock(base::Bind(
+ &AppChildControllerImpl::StartAppOnMainThread,
+ base::FilePath::FromUTF8Unsafe(app_path),
+ static_cast<DynamicServiceRunner::CleanupBehavior>(cleanup_behavior),
+ base::Passed(&service)));
}
private:
@@ -205,15 +208,18 @@ class AppChildControllerImpl : public InterfaceImpl<AppChildController> {
channel_info_ = channel_info;
}
- static void StartAppOnMainThread(const base::FilePath& app_path,
- ScopedMessagePipeHandle service) {
+ static void StartAppOnMainThread(
+ const base::FilePath& app_path,
+ DynamicServiceRunner::CleanupBehavior cleanup_behavior,
+ ScopedMessagePipeHandle service) {
// TODO(vtl): This is copied from in_process_dynamic_service_runner.cc.
DVLOG(2) << "Loading/running Mojo app from " << app_path.value()
<< " out of process";
// We intentionally don't unload the native library as its lifetime is the
// same as that of the process.
- DynamicServiceRunner::LoadAndRunService(app_path, service.Pass());
+ DynamicServiceRunner::LoadAndRunService(app_path, cleanup_behavior,
+ service.Pass());
}
base::ThreadChecker thread_checker_;

Powered by Google App Engine
This is Rietveld 408576698