Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: shell/dynamic_service_runner.h

Issue 865253002: Delete temporary application file as soon as the application is launched. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: clang format Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/dynamic_service_runner.h
diff --git a/shell/dynamic_service_runner.h b/shell/dynamic_service_runner.h
index 7408789ca3253a6e175a833e0552481d03d28ea5..0dc49405af60df575c713cacf864214abe46a5e6 100644
--- a/shell/dynamic_service_runner.h
+++ b/shell/dynamic_service_runner.h
@@ -25,10 +25,12 @@ class DynamicServiceRunner {
public:
virtual ~DynamicServiceRunner() {}
- // Takes ownership of the file at |app_path|. Loads the app in that file and
- // runs it on some other thread/process. |app_completed_callback| is posted
- // (to the thread on which |Start()| was called) after |MojoMain()| completes.
+ // Loads the app in the file at |app_path| and runs it on some other
+ // thread/process. If |clean_app_path| is |true|, takes ownership of the file.
+ // |app_completed_callback| is posted (to the thread on which |Start()| was
+ // called) after |MojoMain()| completes.
virtual void Start(const base::FilePath& app_path,
+ bool clean_app_path,
Aaron Boodman 2015/01/22 19:51:31 Recommend using an enum as suggested by eseidel fo
qsr 2015/01/26 09:12:13 Done.
ScopedMessagePipeHandle service_handle,
const base::Closure& app_completed_callback) = 0;
@@ -39,6 +41,7 @@ class DynamicServiceRunner {
// thread is destroyed and any thread-local destructors have been executed.
static base::NativeLibrary LoadAndRunService(
const base::FilePath& app_path,
+ bool clean_app_path,
ScopedMessagePipeHandle service_handle);
};

Powered by Google App Engine
This is Rietveld 408576698