Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: shell/dynamic_service_runner.h

Issue 865253002: Delete temporary application file as soon as the application is launched. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SHELL_DYNAMIC_SERVICE_RUNNER_H_ 5 #ifndef SHELL_DYNAMIC_SERVICE_RUNNER_H_
6 #define SHELL_DYNAMIC_SERVICE_RUNNER_H_ 6 #define SHELL_DYNAMIC_SERVICE_RUNNER_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/native_library.h" 10 #include "base/native_library.h"
11 #include "mojo/public/cpp/system/core.h" 11 #include "mojo/public/cpp/system/core.h"
12 12
13 namespace base { 13 namespace base {
14 class FilePath; 14 class FilePath;
15 } 15 }
16 16
17 namespace mojo { 17 namespace mojo {
18 namespace shell { 18 namespace shell {
19 19
20 class Context; 20 class Context;
21 21
22 // Abstraction for loading a service (from the file system) and running it (on 22 // Abstraction for loading a service (from the file system) and running it (on
23 // another thread or in a separate process). 23 // another thread or in a separate process).
24 class DynamicServiceRunner { 24 class DynamicServiceRunner {
25 public: 25 public:
26 virtual ~DynamicServiceRunner() {} 26 virtual ~DynamicServiceRunner() {}
27 27
28 // Takes ownership of the file at |app_path|. Loads the app in that file and 28 // Parameter for |Start| to specify its cleanup behavior.
29 // runs it on some other thread/process. |app_completed_callback| is posted 29 enum CleanupBehavior { DeleteAppPath, DontDeleteAppPath };
30 // (to the thread on which |Start()| was called) after |MojoMain()| completes. 30
31 // Loads the app in the file at |app_path| and runs it on some other
32 // thread/process. If |cleanup_behavior| is |true|, takes ownership of the
33 // file. |app_completed_callback| is posted (to the thread on which |Start()|
34 // was called) after |MojoMain()| completes.
31 virtual void Start(const base::FilePath& app_path, 35 virtual void Start(const base::FilePath& app_path,
36 DynamicServiceRunner::CleanupBehavior cleanup_behavior,
32 ScopedMessagePipeHandle service_handle, 37 ScopedMessagePipeHandle service_handle,
33 const base::Closure& app_completed_callback) = 0; 38 const base::Closure& app_completed_callback) = 0;
34 39
35 // Loads the service in the DSO specificed by |app_path| and prepares it for 40 // Loads the service in the DSO specificed by |app_path| and prepares it for
36 // execution. Runs the DSO's exported function MojoMain(). 41 // execution. Runs the DSO's exported function MojoMain().
37 // The NativeLibrary is returned and ownership transferred to the caller. 42 // The NativeLibrary is returned and ownership transferred to the caller.
38 // This is so if it is unloaded at all, this can be done safely after this 43 // This is so if it is unloaded at all, this can be done safely after this
39 // thread is destroyed and any thread-local destructors have been executed. 44 // thread is destroyed and any thread-local destructors have been executed.
40 static base::NativeLibrary LoadAndRunService( 45 static base::NativeLibrary LoadAndRunService(
41 const base::FilePath& app_path, 46 const base::FilePath& app_path,
47 DynamicServiceRunner::CleanupBehavior cleanup_behavior,
42 ScopedMessagePipeHandle service_handle); 48 ScopedMessagePipeHandle service_handle);
43 }; 49 };
44 50
45 class DynamicServiceRunnerFactory { 51 class DynamicServiceRunnerFactory {
46 public: 52 public:
47 virtual ~DynamicServiceRunnerFactory() {} 53 virtual ~DynamicServiceRunnerFactory() {}
48 virtual scoped_ptr<DynamicServiceRunner> Create(Context* context) = 0; 54 virtual scoped_ptr<DynamicServiceRunner> Create(Context* context) = 0;
49 }; 55 };
50 56
51 // A generic factory. 57 // A generic factory.
52 template <class DynamicServiceRunnerImpl> 58 template <class DynamicServiceRunnerImpl>
53 class DynamicServiceRunnerFactoryImpl : public DynamicServiceRunnerFactory { 59 class DynamicServiceRunnerFactoryImpl : public DynamicServiceRunnerFactory {
54 public: 60 public:
55 DynamicServiceRunnerFactoryImpl() {} 61 DynamicServiceRunnerFactoryImpl() {}
56 virtual ~DynamicServiceRunnerFactoryImpl() {} 62 virtual ~DynamicServiceRunnerFactoryImpl() {}
57 virtual scoped_ptr<DynamicServiceRunner> Create(Context* context) override { 63 virtual scoped_ptr<DynamicServiceRunner> Create(Context* context) override {
58 return scoped_ptr<DynamicServiceRunner>( 64 return scoped_ptr<DynamicServiceRunner>(
59 new DynamicServiceRunnerImpl(context)); 65 new DynamicServiceRunnerImpl(context));
60 } 66 }
61 }; 67 };
62 68
63 } // namespace shell 69 } // namespace shell
64 } // namespace mojo 70 } // namespace mojo
65 71
66 #endif // SHELL_DYNAMIC_SERVICE_RUNNER_H_ 72 #endif // SHELL_DYNAMIC_SERVICE_RUNNER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698