Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 865243002: Put close_gif() in an anonymous namespace. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Put close_gif() in an anonymous namespace. Not a big deal, but matches the intention of it being a file-scoped function better. This mirrors a recent google3 change for clients who don't use C++11. BUG=skia: Committed: https://skia.googlesource.com/skia/+/75de4f827fcc92ec129ba872924f6e81c55aa8f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/images/SkImageDecoder_libgif.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 11 months ago (2015-01-22 16:12:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865243002/1
5 years, 11 months ago (2015-01-22 16:14:04 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 16:14:05 UTC) #5
scroggo
lgtm
5 years, 11 months ago (2015-01-22 18:32:06 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 18:32:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/75de4f827fcc92ec129ba872924f6e81c55aa8f0

Powered by Google App Engine
This is Rietveld 408576698