Replace all usage of LOG(INFO) in Chromoting host with HOST_LOG to bypass the presubmit check.

Replace all usage of LOG(INFO) in Chromoting host with HOST_LOG to bypass the presubmit check. This won't spam the chrome output because the chromoting host code doesn't run in the chrome processes.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237431

[Sergey Ulanov, 2013-11-26 02:58:57]

https://codereview.chromium.org/86523005/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/86523005/diff/20001/PRESUBMIT.py#newcode836
PRESUBMIT.py:836: r"^base[\\\/]remoting[\\\/]logging\.h$",))
remoting/base/logging.h

https://codereview.chromium.org/86523005/diff/20001/remoting/base/logging.h
File remoting/base/logging.h (right):

https://codereview.chromium.org/86523005/diff/20001/remoting/base/logging.h#n...
remoting/base/logging.h:14: #define LOG_INFO LOG(INFO)
I suggest to call it HOST_LOG.

[weitao, 2013-11-26 18:06:08]

https://codereview.chromium.org/86523005/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/86523005/diff/20001/PRESUBMIT.py#newcode836
PRESUBMIT.py:836: r"^base[\\\/]remoting[\\\/]logging\.h$",))
On 2013/11/26 02:58:59, Sergey Ulanov wrote:
> remoting/base/logging.h

Done.

https://codereview.chromium.org/86523005/diff/20001/remoting/base/logging.h
File remoting/base/logging.h (right):

https://codereview.chromium.org/86523005/diff/20001/remoting/base/logging.h#n...
remoting/base/logging.h:14: #define LOG_INFO LOG(INFO)
I think we discussed the possibility of defining the macro to use different
logging facility depending on the target (host vs. client vs tools, etc). e.g.
#ifdef xxx_HOST_xxx
#define LOG_INFO xxxxxxx
#else
#define LOG_INFO yyyyyyy
#endif

Then shouldn't we use a more general term than HOST_LOG?

On 2013/11/26 02:58:59, Sergey Ulanov wrote:
> I suggest to call it HOST_LOG.

[weitao, 2013-11-26 19:26:20]

Sergey, PTAL.
Joi, could you please review the change in PRESUBMIT.py? I need to white list
remoting/base/logging.h to bypass the recently added _CheckSpamLogging check.

https://codereview.chromium.org/86523005/diff/20001/remoting/base/logging.h
File remoting/base/logging.h (right):

https://codereview.chromium.org/86523005/diff/20001/remoting/base/logging.h#n...
remoting/base/logging.h:14: #define LOG_INFO LOG(INFO)
Ranamed to HOST_LOG after discussing with Sergey. We can always rename if there
is a need in the future.

On 2013/11/26 18:06:08, weitaosu wrote:
> I think we discussed the possibility of defining the macro to use different
> logging facility depending on the target (host vs. client vs tools, etc). e.g.
> #ifdef xxx_HOST_xxx
> #define LOG_INFO xxxxxxx
> #else
> #define LOG_INFO yyyyyyy
> #endif
> 
> Then shouldn't we use a more general term than HOST_LOG?
> 
> On 2013/11/26 02:58:59, Sergey Ulanov wrote:
> > I suggest to call it HOST_LOG.
>

[Sergey Ulanov, 2013-11-26 19:56:27]

LGTM. Thanks!

https://codereview.chromium.org/86523005/diff/50001/remoting/host/host_status...
File remoting/host/host_status_sender_unittest.cc (right):

https://codereview.chromium.org/86523005/diff/50001/remoting/host/host_status...
remoting/host/host_status_sender_unittest.cc:91: HOST_LOG << stanza->Str();
I don't think we need this. It spams console from unittests, that's not what we
should be using HOST_LOG for. Same for other logs in this unittest

[weitao, 2013-11-26 19:59:01]

M-A Ruel, could you please review my change in PRESUBMIT.py?

[weitao, 2013-11-26 20:03:04]

https://codereview.chromium.org/86523005/diff/50001/remoting/host/host_status...
File remoting/host/host_status_sender_unittest.cc (right):

https://codereview.chromium.org/86523005/diff/50001/remoting/host/host_status...
remoting/host/host_status_sender_unittest.cc:91: HOST_LOG << stanza->Str();
On 2013/11/26 19:56:28, Sergey Ulanov wrote:
> I don't think we need this. It spams console from unittests, that's not what
we
> should be using HOST_LOG for. Same for other logs in this unittest

Done.

[M-A Ruel, 2013-11-26 20:18:04]

presubmit lgtm

[commit-bot: I haz the power, 2013-11-26 20:19:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/weitaosu@chromium.org/86523005/70001

[commit-bot: I haz the power, 2013-11-26 20:35:26]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-26 21:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/weitaosu@chromium.org/86523005/90001

[commit-bot: I haz the power, 2013-11-26 23:19:52]

Change committed as 237431