Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 865183002: [turbofan] Add STYLE document. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add STYLE document. R=titzer@chromium.org Committed: https://crrev.com/cd584c2dea6ac7d620076d57d0fc0b1f8dd86f13 Cr-Commit-Position: refs/heads/master@{#26221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A src/compiler/STYLE View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-22 13:41:58 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-22 13:42:11 UTC) #2
titzer
LGTM and you can take out related comments in pipeline.h
5 years, 11 months ago (2015-01-22 13:44:37 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as cd584c2dea6ac7d620076d57d0fc0b1f8dd86f13 (presubmit successful).
5 years, 11 months ago (2015-01-22 13:47:31 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 13:47:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd584c2dea6ac7d620076d57d0fc0b1f8dd86f13
Cr-Commit-Position: refs/heads/master@{#26221}

Powered by Google App Engine
This is Rietveld 408576698