chrome/browser/ui/views/bookmarks/bookmark_context_menu.h - Issue 865163003: bookmarks: Move BookmarkNode into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

Issue 865163003: bookmarks: Move BookmarkNode into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac fixes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc » ('j') | components/enhanced_bookmarks/bookmark_image_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

index 4631eaadadfd1e1c35ebc9533908f64aa2f4298c..b90099afc955d8723dce012fb4f418253b8ae17a 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

@@ -21,7 +21,7 @@ class BookmarkContextMenuObserver {

public:

// Invoked before the specified items are removed from the bookmark model.

virtual void WillRemoveBookmarks(

- const std::vector<const BookmarkNode*>& bookmarks) = 0;

+ const std::vector<const bookmarks::BookmarkNode*>& bookmarks) = 0;

// Invoked after the items have been removed from the model.

virtual void DidRemoveBookmarks() = 0;

@@ -39,8 +39,8 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate,

Browser* browser,

Profile* profile,

content::PageNavigator* page_navigator,

- const BookmarkNode* parent,

- const std::vector<const BookmarkNode*>& selection,

+ const bookmarks::BookmarkNode* parent,

+ const std::vector<const bookmarks::BookmarkNode*>& selection,

bool close_on_remove);

~BookmarkContextMenu() override;

@@ -68,7 +68,7 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate,

void CloseMenu() override;

void WillExecuteCommand(

int command_id,

- const std::vector<const BookmarkNode*>& bookmarks) override;

+ const std::vector<const bookmarks::BookmarkNode*>& bookmarks) override;

void DidExecuteCommand(int command_id) override;

private: