Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 865153004: Remove dead code related to compositing from Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -259 lines) Patch
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/Settings.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/SettingsDelegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 6 chunks +2 lines, -113 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 9 chunks +7 lines, -50 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/testing/DummyPageHolder.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/platform/Logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/Logging.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebSettings.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-27 22:23:17 UTC) #1
esprehn
lgtm, is the word "ChickenAndEgg" finally gone?
5 years, 11 months ago (2015-01-27 22:26:17 UTC) #3
abarth-chromium
Yes! I checked specifically.
5 years, 11 months ago (2015-01-27 22:38:29 UTC) #4
abarth-chromium
5 years, 11 months ago (2015-01-27 22:39:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2f3aedc6bb17552d26edfdeaf3882d9b6f628038 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698