src/mips/codegen-mips.cc - Issue 865153002: MIPS: Fix rare random crashes in keyed store if element transition is needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/codegen-mips.cc

Issue 865153002: MIPS: Fix rare random crashes in keyed store if element transition is needed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add mips64 part. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/codegen-mips.cc

diff --git a/src/mips/codegen-mips.cc b/src/mips/codegen-mips.cc

index 0e28eed8001a524469d08a9c8dd2aa93eed7dabb..9188f7b2b0374069348f4ee2c909b35d21fa9e40 100644

--- a/src/mips/codegen-mips.cc

+++ b/src/mips/codegen-mips.cc

@@ -750,7 +750,7 @@ void ElementsTransitionGenerator::GenerateSmiToDouble(

OMIT_SMI_CHECK);

// Replace receiver's backing store with newly created FixedDoubleArray.

__ Addu(scratch1, array, Operand(kHeapObjectTag));

- __ sw(scratch1, FieldMemOperand(a2, JSObject::kElementsOffset));

+ __ sw(scratch1, FieldMemOperand(receiver, JSObject::kElementsOffset));

__ RecordWriteField(receiver,

JSObject::kElementsOffset,

scratch1,

« no previous file with comments | « no previous file | src/mips64/codegen-mips64.cc » ('j') | no next file with comments »