Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 865153002: MIPS: Fix rare random crashes in keyed store if element transition is needed. (Closed)

Created:
5 years, 11 months ago by dusmil.imgtec
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix rare random crashes in keyed store if element transition is needed. TEST=mjsunit/sin-cos BUG= R=balazs.kilvady@imgtec.com Committed: https://chromium.googlesource.com/v8/v8/+/037c73972e5d1ad627f8278afa189bcfa9689632

Patch Set 1 #

Patch Set 2 : Add mips64 part. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/codegen-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
dusmil.imgtec
5 years, 11 months ago (2015-01-22 11:46:48 UTC) #2
dusmil.imgtec
PTAL.
5 years, 11 months ago (2015-01-22 12:56:42 UTC) #3
balazs.kilvady
lgtm
5 years, 11 months ago (2015-01-22 13:53:59 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/037c73972e5d1ad627f8278afa189bcfa9689632 Cr-Commit-Position: refs/heads/master@{#26223}
5 years, 11 months ago (2015-01-22 15:04:57 UTC) #5
dusmil.imgtec
5 years, 11 months ago (2015-01-22 15:05:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
037c73972e5d1ad627f8278afa189bcfa9689632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698