Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 865123003: Update {virtual,override,final} to follow C++11 style in content, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in content, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7 Cr-Commit-Position: refs/heads/master@{#312970}

Patch Set 1 #

Patch Set 2 : Fix format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M content/browser/geolocation/wifi_data_provider_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/net_info_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/time_zone_monitor_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:30:28 UTC) #2
Pawel Osciak
content/common/gpu/media/ lgtm
5 years, 11 months ago (2015-01-23 00:17:16 UTC) #4
no sievers
lgtm
5 years, 11 months ago (2015-01-23 20:30:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865123003/20001
5 years, 11 months ago (2015-01-23 23:01:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 23:57:39 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 23:58:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/341874814d31faf091af39f4c20c98148d79d5a7
Cr-Commit-Position: refs/heads/master@{#312970}

Powered by Google App Engine
This is Rietveld 408576698