Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 865113002: Add allocator shim test to ffmpeg test suite. (Closed)

Created:
5 years, 11 months ago by Will Harris
Modified:
5 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@allocatorfix1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add allocator shim test to ffmpeg test suite. This just verifies that the allocator shim is correctly installed on Windows, the rest of the allocator shim tests are in base_unittests and allocator_unittests. This depends on https://codereview.chromium.org/868533003/ and https://gerrit.chromium.org/gerrit/#/c/73563 BUG=450676 TEST=media_unittests Committed: https://crrev.com/8ec02a10ee3d563034b5a53552b612ad7f15d834 Cr-Commit-Position: refs/heads/master@{#312841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M media/ffmpeg/ffmpeg_common_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Will Harris
5 years, 11 months ago (2015-01-22 04:43:20 UTC) #2
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-22 18:37:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865113002/1
5 years, 11 months ago (2015-01-23 06:58:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/25148)
5 years, 11 months ago (2015-01-23 07:13:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865113002/1
5 years, 11 months ago (2015-01-23 08:13:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/25146)
5 years, 11 months ago (2015-01-23 08:13:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865113002/1
5 years, 11 months ago (2015-01-23 14:36:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 14:37:40 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 14:38:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ec02a10ee3d563034b5a53552b612ad7f15d834
Cr-Commit-Position: refs/heads/master@{#312841}

Powered by Google App Engine
This is Rietveld 408576698