Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 865103002: fLuminance is unsed unless SK_GAMMA_APPLY_TO_A8 is defined (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
jvanverth1, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fLuminance is unsed unless SK_GAMMA_APPLY_TO_A8 is defined BUG=skia: Committed: https://skia.googlesource.com/skia/+/50282b4390dcddcf3b1d51631c0133045ae1f233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
5 years, 11 months ago (2015-01-22 03:06:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865103002/1
5 years, 11 months ago (2015-01-22 03:07:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 03:07:07 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 11 months ago (2015-01-22 09:07:07 UTC) #7
jvanverth1
lgtm
5 years, 11 months ago (2015-01-22 15:56:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865103002/1
5 years, 11 months ago (2015-01-22 15:59:47 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 15:59:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/50282b4390dcddcf3b1d51631c0133045ae1f233

Powered by Google App Engine
This is Rietveld 408576698