Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 865093003: Add a missing #include, to fix the Windows build. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth
Modified:
5 years, 10 months ago
Reviewers:
JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/IceUtils.h View 1 chunk +1 line, -0 lines 4 comments Download

Messages

Total messages: 7 (1 generated)
Jim Stichnoth
5 years, 10 months ago (2015-01-28 16:41:19 UTC) #2
JF
lgtm with nit. https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h File src/IceUtils.h (right): https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h#newcode10 src/IceUtils.h:10: // This file declares some utility ...
5 years, 10 months ago (2015-01-28 16:54:27 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h File src/IceUtils.h (right): https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h#newcode10 src/IceUtils.h:10: // This file declares some utility functions On 2015/01/28 ...
5 years, 10 months ago (2015-01-28 16:55:22 UTC) #4
Jim Stichnoth
Committed patchset #1 (id:1) manually as 1573e08173ec9a015a9661e944d0bd910a678fc3 (presubmit successful).
5 years, 10 months ago (2015-01-28 16:55:31 UTC) #5
JF
https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h File src/IceUtils.h (right): https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h#newcode18 src/IceUtils.h:18: #include <mutex> Actually, instead of being snarky and having ...
5 years, 10 months ago (2015-01-28 22:06:43 UTC) #6
JF
5 years, 10 months ago (2015-01-28 22:19:22 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h
File src/IceUtils.h (right):

https://codereview.chromium.org/865093003/diff/1/src/IceUtils.h#newcode18
src/IceUtils.h:18: #include <mutex>
On 2015/01/28 22:06:42, JF wrote:
> Actually, instead of being snarky and having fun I should have pointed out
that
> <condition_variable> was the header you wanted.

Fixed here:
  https://codereview.chromium.org/884283002/

Powered by Google App Engine
This is Rietveld 408576698