Report unchecked error in lastError.run

extensions/renderer/resources/send_request.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var exceptionHandler = require('uncaught_exception_handler');
 var lastError = require('lastError');
 var logging = requireNative('logging');
 var natives = requireNative('sendRequest');
 var validate = require('schemaUtils').validate;
 
@@ skipping 55 matching lines @@
       // calls may not return data if they observe the caller
       // has not provided a callback.
       if (logging.DCHECK_IS_ON() && !error) {
         if (!request.callbackSchema.parameters)
           throw new Error(name + ": no callback schema defined");
         validate(responseList, request.callbackSchema.parameters);
       }
       safeCallbackApply(name, request, request.callback, responseList);
     }
 
-    if (error &&
-        !lastError.hasAccessed(chrome) &&
-        !lastError.hasAccessed(callerChrome)) {
-      // The native call caused an error, but the developer didn't check
-      // runtime.lastError.
-      // Notify the developer of the error via the (error) console.
-      console.error("Unchecked runtime.lastError while running " +
-          (name || "unknown") + ": " + error +
-          (request.stack ? "\n" + request.stack : ""));
+    if (error && !lastError.hasAccessed(chrome)) {

[not at google - send to devlin, 2015/01/22 18:01:33]

The second part of this condition is unnecessary given reportIfUnchecked (well
named) checks it.

[robwu, 2015/01/22 18:07:22]

Look at the original code, there is a check for |chrome| and |callerChrome|.

[not at google - send to devlin, 2015/01/22 18:12:53]

Ok, add a comment.

[robwu, 2015/01/22 18:19:33]

The purpose of |chrome| and |callerChrome| is already explained in a comment at
the top of the function (about twice, actually).

+      // The native call caused an error, but the developer might not have
+      // checked runtime.lastError.
+      lastError.reportIfUnchecked(name, targetChrome, request.stack);
     }
   } finally {
     delete requests[requestId];
     lastError.clear(chrome);
     if (callerChrome !== chrome)
       lastError.clear(callerChrome);
   }
 }
 
 function prepareRequest(args, argSchemas) {
@@ skipping 18 matching lines @@
 
 // Send an API request and optionally register a callback.
 // |optArgs| is an object with optional parameters as follows:
 // - customCallback: a callback that should be called instead of the standard
 //   callback.
 // - nativeFunction: the v8 native function to handle the request, or
 //   StartRequest if missing.
 // - forIOThread: true if this function should be handled on the browser IO
 //   thread.
 // - preserveNullInObjects: true if it is safe for null to be in objects.
+// - stack: An optional string that contains the stack trace, to be displayed
+//   to the user if an error occurs.
 function sendRequest(functionName, args, argSchemas, optArgs) {
   calledSendRequest = true;
   if (!optArgs)
     optArgs = {};
   var request = prepareRequest(args, argSchemas);
-  request.stack = exceptionHandler.getExtensionStackTrace();
+  request.stack = optArgs.stack || exceptionHandler.getExtensionStackTrace();
   if (optArgs.customCallback) {
     request.customCallback = optArgs.customCallback;
   }
 
   var nativeFunction = optArgs.nativeFunction || natives.StartRequest;
 
   var requestId = natives.GetNextRequestId();
   request.id = requestId;
   requests[requestId] = request;
 
@@ skipping 14 matching lines @@
   calledSendRequest = false;
 }
 
 exports.sendRequest = sendRequest;
 exports.getCalledSendRequest = getCalledSendRequest;
 exports.clearCalledSendRequest = clearCalledSendRequest;
 exports.safeCallbackApply = safeCallbackApply;
 
 // Called by C++.
 exports.handleResponse = handleResponse;