Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 865033002: Implement a slide-in pane for bookmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pdf-pane
Patch Set: Add checks when setting attributes on bookmarksPane Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/pdf/index-material.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js
index fb4d3ee53a3d7d19b7c918089fcc09b3de7097a1..a17b29f3ba0ea239b4efce02f5b9a323540ac032 100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -66,6 +66,7 @@ function PDFViewer(streamDetails) {
this.onPasswordSubmitted_.bind(this));
this.errorScreen_ = $('error-screen');
this.toolbarHeight_ = this.isMaterial_ ? $('pdf-toolbar').clientHeight : 0;
+ this.bookmarksPane = $('bookmarks-pane');
// Create the viewport.
this.viewport_ = new Viewport(window,
@@ -116,6 +117,12 @@ function PDFViewer(streamDetails) {
this.viewport_.goToPage(e.detail.page);
}.bind(this));
+ if (this.isMaterial_) {
+ this.bookmarksPane.addEventListener('changePage', function(e) {
+ this.viewport_.goToPage(e.detail.page);
+ }.bind(this));
+ }
+
// Setup the button event listeners.
$('fit-to-width-button').addEventListener('click',
this.viewport_.fitToWidth.bind(this.viewport_));
@@ -127,6 +134,11 @@ function PDFViewer(streamDetails) {
this.viewport_.zoomOut.bind(this.viewport_));
$('save-button').addEventListener('click', this.save_.bind(this));
$('print-button').addEventListener('click', this.print_.bind(this));
+ if (this.isMaterial_) {
+ $('bookmarks-button').addEventListener('click', function() {
+ this.bookmarksPane.toggle();
+ }.bind(this));
+ }
// Setup the keyboard event listener.
document.onkeydown = this.handleKeyEvent_.bind(this);
@@ -449,6 +461,8 @@ PDFViewer.prototype = {
break;
case 'bookmarks':
this.bookmarks_ = message.data.bookmarks;
+ if (this.isMaterial_)
+ this.bookmarksPane.bookmarks = message.data.bookmarks;
break;
}
},
« no previous file with comments | « chrome/browser/resources/pdf/index-material.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698