Implement a slide-in pane for bookmarks.

chrome/browser/resources/pdf/pdf.js

Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js
index b6d5caa5d35079af211be6911ac116be1d88236d..544fea9d68ef18024011f6fa2429aec17d99d21a 100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -66,6 +66,7 @@ function PDFViewer(streamDetails) {
                                         this.onPasswordSubmitted_.bind(this));
   this.errorScreen_ = $('error-screen');
   this.toolbarHeight_ = this.isMaterial_ ? $('pdf-toolbar').clientHeight : 0;
+  this.bookmarksPane = $('bookmarks-pane');
 
   // Create the viewport.
   this.viewport_ = new Viewport(window,
@@ -112,6 +113,10 @@ function PDFViewer(streamDetails) {
     this.plugin_.setAttribute('full-frame', '');
   document.body.appendChild(this.plugin_);
 
+  this.bookmarksPane.addEventListener('changePage', function(e) {
+    this.viewport_.goToPage(e.detail.page);
+  }.bind(this));
+
   // Setup the button event listeners.
   $('fit-to-width-button').addEventListener('click',
       this.viewport_.fitToWidth.bind(this.viewport_));
@@ -123,6 +128,11 @@ function PDFViewer(streamDetails) {
       this.viewport_.zoomOut.bind(this.viewport_));
   $('save-button').addEventListener('click', this.save_.bind(this));
   $('print-button').addEventListener('click', this.print_.bind(this));
+  if (this.isMaterial_) {
+    $('bookmarks-button').addEventListener('click', function() {
+      this.bookmarksPane.toggle();
+    }.bind(this));
+  }
 
   // Setup the keyboard event listener.
   document.onkeydown = this.handleKeyEvent_.bind(this);
@@ -378,8 +388,10 @@ PDFViewer.prototype = {
         if (this.passwordScreen_.active)
           this.passwordScreen_.accept();
 
-        this.pageIndicator_.initialFadeIn();
-        this.toolbar_.initialFadeIn();
+        if (!this.isMaterial_) {
+          this.pageIndicator_.initialFadeIn();
+          this.toolbar_.initialFadeIn();
+        }
         break;
       case 'email':
         var href = 'mailto:' + message.data.to + '?cc=' + message.data.cc +
@@ -436,7 +448,7 @@ PDFViewer.prototype = {
         chrome.mimeHandlerPrivate.abortStream();
         break;
       case 'bookmarks':
-        this.bookmarks_ = message.data.bookmarks;
+        this.bookmarksPane.bookmarks = message.data.bookmarks;
         break;
     }
   },
@@ -684,6 +696,9 @@ PDFViewer.prototype = {
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
-    return this.bookmarks_;
+    if (this.isMaterial_)
+      return this.bookmarksPane.bookmarks;

[raymes, 2015/01/29 04:55:07]

Actually now that you've written it, I realised this will cause the bookmarks
test to fail. Let's keep this as an instance variable instead (this.bookmarks).
Sorry about that!

[Alexandre Carlton, 2015/01/29 05:39:06]

Done.

+    else
+      return [];
   }
 };