Certificate Transparency: Logging SCTs to the NetLog.

net/cert/multi_log_ct_verifier_unittest.cc

Index: net/cert/multi_log_ct_verifier_unittest.cc
diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc
index 287b15036ef520994d3fb33f1e6cdf269ccbe6e5..2fb7a6ebce2bf21265a8e6942482080aef0d6088 100644
--- a/net/cert/multi_log_ct_verifier_unittest.cc
+++ b/net/cert/multi_log_ct_verifier_unittest.cc
@@ -9,6 +9,7 @@
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "net/base/net_errors.h"
+#include "net/base/net_log.h"
 #include "net/base/test_data_directory.h"
 #include "net/cert/ct_log_verifier.h"
 #include "net/cert/ct_serialization.h"
@@ -55,7 +56,7 @@ class MultiLogCTVerifierTest : public ::testing::Test {
 
   bool CheckPrecertificateVerification(scoped_refptr<X509Certificate> chain) {
     ct::CTVerifyResult result;
-    return (verifier_->Verify(chain, "", "", &result) == OK) &&
+    return (verifier_->Verify(chain, "", "", &result, BoundNetLog()) == OK) &&
         CheckForSingleVerifiedSCTInResult(result) &&
         CheckForSCTOrigin(
             result, ct::SignedCertificateTimestamp::SCT_EMBEDDED);
@@ -111,7 +112,8 @@ TEST_F(MultiLogCTVerifierTest,
   ASSERT_TRUE(ct::EncodeSCTListForTesting(sct, &sct_list));
 
   ct::CTVerifyResult result;
-  EXPECT_EQ(OK, verifier_->Verify(chain_, "", sct_list, &result));
+  EXPECT_EQ(OK,
+      verifier_->Verify(chain_, "", sct_list, &result, BoundNetLog()));
   ASSERT_TRUE(CheckForSingleVerifiedSCTInResult(result));
   ASSERT_TRUE(CheckForSCTOrigin(
       result, ct::SignedCertificateTimestamp::SCT_FROM_TLS_EXTENSION));
@@ -129,7 +131,8 @@ TEST_F(MultiLogCTVerifierTest,
   ASSERT_TRUE(ct::EncodeSCTListForTesting(sct, &sct_list));
 
   ct::CTVerifyResult result;
-  EXPECT_NE(OK, verifier_->Verify(chain_, sct_list, "", &result));
+  EXPECT_NE(OK,
+      verifier_->Verify(chain_, sct_list, "", &result, BoundNetLog()));

[eroman, 2013/11/27 22:33:46]

For extra credit, add a unittest which passes a CapturingBoundNetLog and then
verify the logged events.

[Eran M. (Google), 2013/11/29 11:14:44]

Done - the CapturedEntry is lacking methods to query the underlying params for
dictionary values, so I could only verify one of the logged events, not the
other. Will add the necessary methods next week.

   EXPECT_EQ(1U, result.unknown_logs_scts.size());
 }