Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: net/base/net_log_event_type_list.h

Issue 86503002: Certificate Transparency: Logging SCTs to the NetLog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address *all* comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index f31bccae3656a6b07a77054f779b16d8c7dd63b9..e89cf9143060b1c3fcbce047f307f8f173924760 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -558,6 +558,38 @@ EVENT_TYPE(SOCKET_WRITE_ERROR)
// }
EVENT_TYPE(SSL_CERTIFICATES_RECEIVED)
+// Signed Certificate Timestamps were received from the server.
+// The following parameters are attached to the event:
+// {
+// "embedded_scts": Base64-encoded SignedCertificateTimestampList,
+// "scts_from_ocsp_response": Base64-encoded SignedCertificateTimestampList,
+// "scts_from_tls_extension": Base64-encoded SignedCertificateTimestampList,
+// }
+//
+// The SignedCertificateTimestampList is defined in RFC6962 and is exactly as
+// received from the server.
+EVENT_TYPE(SIGNED_CERTIFICATE_TIMESTAMPS_RECEIVED)
+
+// Signed Certificate Timestamps were checked.
+// The following parameters are attached to the event:
+// {
+// "verified_scts": <A list of SCTs>,
+// "failed_to_verify_scts": <A list of SCTs>,
eroman 2013/11/27 22:33:46 Update this comment to match the code (i.e. unveri
Eran M. (Google) 2013/11/29 11:14:44 Done.
+// "scts_from_unknown_logs": <A list of SCTs>,
+// }
+//
+// Where each SCT is an object:
+// {
+// "origin": <one of: embedded_in_certificate, tls_extension, ocsp>,
eroman 2013/11/27 22:33:46 nit: enclose the options in quotemarks to emphasiz
Eran M. (Google) 2013/11/29 11:14:44 Done.
+// "version": <numeric version>,
+// "log_id": <base64-encoded log id>,
+// "timestamp": <numeric timestamp in milliseconds since the Unix epoch>,
+// "hash_algorithm": <name of the hash algorithm>,
+// "signature_algorithm": <name of the signature algorithm>,
+// "signature_data": <base64-encoded signature bytes>,
+// }
+EVENT_TYPE(SIGNED_CERTIFICATE_TIMESTAMPS_CHECKED)
+
// ------------------------------------------------------------------------
// DatagramSocket
// ------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698