Certificate Transparency: Logging SCTs to the NetLog.

net/cert/ct_verifier.h

Index: net/cert/ct_verifier.h
diff --git a/net/cert/ct_verifier.h b/net/cert/ct_verifier.h
index 22b8d7a5d7caaafd556f8bc2587457a83efd0f58..494e7cb0fa0daf9a3a5a0031b5765e5fdda0f923 100644
--- a/net/cert/ct_verifier.h
+++ b/net/cert/ct_verifier.h
@@ -9,6 +9,8 @@
 
 namespace net {
 
+class BoundNetLog;

[wtc, 2013/11/27 16:00:58]

Nit: move this to line 18, with the other forward declaration.

[Eran M. (Google), 2013/11/27 22:08:50]

Done.

+
 namespace ct {
 struct CTVerifyResult;
 }  // namespace ct
@@ -27,7 +29,8 @@ class NET_EXPORT CTVerifier {
   virtual int Verify(X509Certificate* cert,
                      const std::string& sct_list_from_ocsp,
                      const std::string& sct_list_from_tls_extension,
-                     ct::CTVerifyResult* result) = 0;
+                     ct::CTVerifyResult* result,
+                     const BoundNetLog& net_log) = 0;

[wtc, 2013/11/27 16:00:58]

Nit: this may be OK. Please check whether |net_log| is by convention the last
parameter.

|net_log| is declared as a const reference, which looks like an input, and the
Style Guide recommends listing inputs before outputs.

[Eran M. (Google), 2013/11/27 22:08:50]

It is the case for the CertVerifier (see ssl_client_socket_nss.cc line 3381)

 };
 
 }  // namespace net