Certificate Transparency: Logging SCTs to the NetLog.

net/cert/ct_verifier.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_CT_VERIFIER_H_
 #define NET_CERT_CT_VERIFIER_H_
 
 #include "net/base/net_export.h"
 
 namespace net {
 
+class BoundNetLog;

[wtc, 2013/11/27 16:00:58]

Nit: move this to line 18, with the other forward declaration.

[Eran M. (Google), 2013/11/27 22:08:50]

Done.

+
 namespace ct {
 struct CTVerifyResult;
 }  // namespace ct
 
 class X509Certificate;
 
 // Interface for verifying Signed Certificate Timestamps over a certificate.
 class NET_EXPORT CTVerifier {
  public:
   virtual ~CTVerifier() {}
 
   // Verifies either embedded SCTs or SCTs obtained via the
   // signed_certificate_timestamp TLS extension or OCSP on  the given |cert|
   // |result| will be filled with these SCTs, divided into categories based on
   // the verification result.
   virtual int Verify(X509Certificate* cert,
                      const std::string& sct_list_from_ocsp,
                      const std::string& sct_list_from_tls_extension,
-                     ct::CTVerifyResult* result) = 0;
+                     ct::CTVerifyResult* result,
+                     const BoundNetLog& net_log) = 0;

[wtc, 2013/11/27 16:00:58]

Nit: this may be OK. Please check whether |net_log| is by convention the last
parameter.

|net_log| is declared as a const reference, which looks like an input, and the
Style Guide recommends listing inputs before outputs.

[Eran M. (Google), 2013/11/27 22:08:50]

It is the case for the CertVerifier (see ssl_client_socket_nss.cc line 3381)

 };
 
 }  // namespace net
 
 #endif  // NET_CERT_CT_VERIFIER_H_