Certificate Transparency: Logging SCTs to the NetLog.

net/cert/ct_signed_certificate_timestamp_log_param.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_BASE_CT_SIGNED_CERTIFICATE_TIMESTAMP_LOG_PARAM_H_
+#define NET_BASE_CT_SIGNED_CERTIFICATE_TIMESTAMP_LOG_PARAM_H_

[wtc, 2013/11/27 16:00:58]

The include guard macro's name needs to be updated to match the new file
pathname.

[Eran M. (Google), 2013/11/27 22:08:50]

Done.

+
+#include "net/base/net_log.h"

[wtc, 2013/11/27 16:00:58]

Nit: Add a blank line after this line.

[Eran M. (Google), 2013/11/27 22:08:50]

Done.

+namespace net {
+
+namespace ct {
+struct CTVerifyResult;
+}
+
+base::Value* NetLogSignedCertificateTimestampCallback(

[wtc, 2013/11/27 16:00:58]

Nit: should we document these two functions? Or are they standard functions for
NetLog?

[Eran M. (Google), 2013/11/27 22:08:50]

Documented them, also referred to the documentation in net_log_event_type_list.h

+    const ct::CTVerifyResult* ct_result, NetLog::LogLevel log_level);
+
+base::Value* NetLogRawSignedCertificateTimestampCallback(
+    const std::string* embedded_scts,
+    const std::string* sct_list_from_ocsp,
+    const std::string* sct_list_from_tls_extension,
+    NetLog::LogLevel log_level);
+}  // namespace net

[wtc, 2013/11/27 16:00:58]

Nit: Add a blank line before this line.

[Eran M. (Google), 2013/11/27 22:08:50]

Done.

+
+#endif //  NET_BASE_CT_SIGNED_CERTIFICATE_TIMESTAMP_LOG_PARAM_H_

[wtc, 2013/11/27 16:00:58]

Nit: two spaces before "//", one space after "//".

[Eran M. (Google), 2013/11/27 22:08:50]

Almost got it right! Done.