Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 865023002: Delay printing OOP PDF until loading is complete (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simplify-scripting
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay printing OOP PDF until loading is complete This delays the print command in OOP PDF. This simplifies the use of the OOP PDF scripting API so print can be called immediately before the document is loaded. BUG=303491 Committed: https://crrev.com/b59ab7ac8433652b921f2a93289c6d13b862e5a0 Cr-Commit-Position: refs/heads/master@{#312524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -28 lines) Patch
M pdf/out_of_process_instance.h View 2 chunks +4 lines, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 4 chunks +28 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
5 years, 11 months ago (2015-01-22 00:04:08 UTC) #2
Sam McNally
lgtm
5 years, 11 months ago (2015-01-22 00:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865023002/1
5 years, 11 months ago (2015-01-22 00:16:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 02:08:17 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:09:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b59ab7ac8433652b921f2a93289c6d13b862e5a0
Cr-Commit-Position: refs/heads/master@{#312524}

Powered by Google App Engine
This is Rietveld 408576698