Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 864983002: Fix a couple test timeouts. (Closed)

Created:
5 years, 11 months ago by nweiz
Modified:
5 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/json_rpc_2@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M test/server/batch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/server/server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/server/utils.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 11 months ago (2015-01-21 22:21:28 UTC) #1
Bob Nystrom
https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart File test/server/utils.dart (right): https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart#newcode66 test/server/utils.dart:66: // Should not be called. I'm having trouble following ...
5 years, 11 months ago (2015-01-21 23:14:30 UTC) #2
nweiz
https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart File test/server/utils.dart (right): https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart#newcode66 test/server/utils.dart:66: // Should not be called. On 2015/01/21 23:14:30, Bob ...
5 years, 11 months ago (2015-01-22 00:05:45 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart File test/server/utils.dart (right): https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart#newcode66 test/server/utils.dart:66: // Should not be called. On 2015/01/22 00:05:45, ...
5 years, 11 months ago (2015-01-22 00:08:22 UTC) #4
nweiz
https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart File test/server/utils.dart (right): https://codereview.chromium.org/864983002/diff/1/test/server/utils.dart#newcode66 test/server/utils.dart:66: // Should not be called. On 2015/01/22 00:08:22, Bob ...
5 years, 11 months ago (2015-01-22 00:15:24 UTC) #5
nweiz
5 years, 11 months ago (2015-01-22 00:16:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
809dba9bc9e95de0062cc2420319f1a745ef5805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698