Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

Issue 864963003: Enable SitePerProcessAccessibilityBrowserTest on more platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more_robust_site_isolation_a11y
Patch Set: Removed debugging, ready for review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/site_per_process_accessibility_browsertest.cc
diff --git a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
index 6daf5abbeb5007ed4610f08043f3367698e9ce80..13eb5897757e6c4f23218ecc87ccb65e8ef9e223 100644
--- a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
+++ b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
@@ -46,13 +46,11 @@ bool AccessibilityTreeIsLoaded(BrowserAccessibilityManager* manager) {
root->GetStringAttribute(ui::AX_ATTR_DOC_URL) != url::kAboutBlankURL);
}
-// TODO(nasko): try enabling this test on more platforms once
-// SitePerProcessBrowserTest.CrossSiteIframe is enabled everywhere.
-// http://crbug.com/399775
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
-#define MAYBE_CrossSiteIframeAccessibility CrossSiteIframeAccessibility
-#else
+// Times out on Android, not clear if it's an actual bug or just slow.
+#if defined(OS_ANDROID)
dmazzoni 2015/01/28 19:29:00 Currently Android only uses one process for all re
nasko 2015/02/03 17:08:18 Are you sure about that? We do run our site-per-pr
dmazzoni 2015/02/03 17:15:29 I'll dig into it more. Maybe I'll land this change
#define MAYBE_CrossSiteIframeAccessibility DISABLED_CrossSiteIframeAccessibility
+#else
+#define MAYBE_CrossSiteIframeAccessibility CrossSiteIframeAccessibility
#endif
IN_PROC_BROWSER_TEST_F(SitePerProcessAccessibilityBrowserTest,
MAYBE_CrossSiteIframeAccessibility) {
« no previous file with comments | « no previous file | content/browser/frame_host/frame_accessibility.cc » ('j') | content/browser/frame_host/frame_accessibility.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698