Enable SitePerProcessAccessibilityBrowserTest on more platforms.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 1556 matching lines @@
 void RenderFrameHostImpl::UpdateCrossProcessIframeAccessibility(
     const std::map<int32, int>& node_to_frame_routing_id_map) {
   for (const auto& iter : node_to_frame_routing_id_map) {
     // This is the id of the accessibility node that has a child frame.
     int32 node_id = iter.first;
     // The routing id from either a RenderFrame or a RenderFrameProxy.
     int frame_routing_id = iter.second;
 
     FrameTree* frame_tree = frame_tree_node()->frame_tree();
     FrameTreeNode* child_frame_tree_node = frame_tree->FindByRoutingID(
-        GetProcess()->GetID(), frame_routing_id);
+        frame_routing_id, GetProcess()->GetID());

[dmazzoni, 2015/01/28 19:29:00]

Holy cow, the parameters were reversed!

It's a *total coincidence* that this test passed on Linux before, because
process IDs and routing IDs are both small integers.

It makes me wonder if we should maybe randomize the first routing id, or typedef
them so that it's harder to accidentally get them mixed up.

[nasko, 2015/02/03 17:08:18]

Also makes me think if we should change the signature of FindByRoutingID, as
lots of other methods have the (process, routing id) ordering. Definitely
different CL though.

+
     if (child_frame_tree_node) {
       FrameAccessibility::GetInstance()->AddChildFrame(
           this, node_id, child_frame_tree_node->frame_tree_node_id());
     }
   }
 }
 
 void RenderFrameHostImpl::UpdateGuestFrameAccessibility(
     const std::map<int32, int>& node_to_browser_plugin_instance_id_map) {
   for (const auto& iter : node_to_browser_plugin_instance_id_map) {
@@ skipping 147 matching lines @@
 void RenderFrameHostImpl::DidUseGeolocationPermission() {
   RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame();
   GetContentClient()->browser()->RegisterPermissionUsage(
       PERMISSION_GEOLOCATION,
       delegate_->GetAsWebContents(),
       GetLastCommittedURL().GetOrigin(),
       top_frame->GetLastCommittedURL().GetOrigin());
 }
 
 }  // namespace content