Chromecast ATV: distinguish actual shutdown vs. lifecycle from sleep.

Chromecast ATV: distinguish actual shutdown vs. lifecycle from sleep.

Activity lifecycle is different when coming out of sleep mode, since
the activity doesn't actually have focus. For whatever reason, this
results in an extra onPause/onStop/onStart/onResume sequence before
the app is "started".

Details: http://stackoverflow.com/questions/25369909/

R=lcwu@chromium.org,byungchul@chromium.org

Committed: https://crrev.com/050bed365f613a1227364055ae19b1e4445f963a
Cr-Commit-Position: refs/heads/master@{#312550}

[byungchul, 2015-01-22 00:48:30]

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java
(right):

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java:198:
mHadFocusWhenPaused = hasWindowFocus();
Is it true when screen goes off?

[gunsch, 2015-01-22 00:52:24]

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java
(right):

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java:198:
mHadFocusWhenPaused = hasWindowFocus();
On 2015/01/22 00:48:30, byungchul wrote:
> Is it true when screen goes off?

Yes.

01-21 16:50:45.348 I/PowerManagerService( 1759): Going to sleep due to power
button (uid 1000)...
01-21 16:50:45.350 D/CastShellActivity( 6070): onPause, window focus = true

[byungchul, 2015-01-22 01:15:20]

lgtm

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java
(right):

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java:198:
mHadFocusWhenPaused = hasWindowFocus();
On 2015/01/22 00:52:24, gunsch wrote:
> On 2015/01/22 00:48:30, byungchul wrote:
> > Is it true when screen goes off?
> 
> Yes.
> 
> 01-21 16:50:45.348 I/PowerManagerService( 1759): Going to sleep due to power
> button (uid 1000)...
> 01-21 16:50:45.350 D/CastShellActivity( 6070): onPause, window focus = true

We should check if that is an intended behavior. At least, we may want to pause
the video playing. Is it handled by media manager anyway?

[gunsch, 2015-01-22 01:26:26]

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java
(right):

https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java:198:
mHadFocusWhenPaused = hasWindowFocus();
On 2015/01/22 01:15:20, byungchul wrote:
> On 2015/01/22 00:52:24, gunsch wrote:
> > On 2015/01/22 00:48:30, byungchul wrote:
> > > Is it true when screen goes off?
> > 
> > Yes.
> > 
> > 01-21 16:50:45.348 I/PowerManagerService( 1759): Going to sleep due to power
> > button (uid 1000)...
> > 01-21 16:50:45.350 D/CastShellActivity( 6070): onPause, window focus = true
> 
> We should check if that is an intended behavior. At least, we may want to
pause
> the video playing. Is it handled by media manager anyway?

Oh, I think I see what you're asking. When screen turns off, generally devices
are going to sleep mode. So this is okay. If we have window focus and we get an
onPause/onStop sequence, it means the system is intentionally trying to shut the
app off, either through direct user action (back/home button on remote) or
indirect (user turned the TV off).

Also note that this CL introduces no behavior change for the case you describe.

[byungchul, 2015-01-22 01:30:52]

On 2015/01/22 01:26:26, gunsch wrote:
>
https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
> File
>
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java
> (right):
> 
>
https://codereview.chromium.org/864923003/diff/1/chromecast/browser/android/a...
>
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java:198:
> mHadFocusWhenPaused = hasWindowFocus();
> On 2015/01/22 01:15:20, byungchul wrote:
> > On 2015/01/22 00:52:24, gunsch wrote:
> > > On 2015/01/22 00:48:30, byungchul wrote:
> > > > Is it true when screen goes off?
> > > 
> > > Yes.
> > > 
> > > 01-21 16:50:45.348 I/PowerManagerService( 1759): Going to sleep due to
power
> > > button (uid 1000)...
> > > 01-21 16:50:45.350 D/CastShellActivity( 6070): onPause, window focus =
true
> > 
> > We should check if that is an intended behavior. At least, we may want to
> pause
> > the video playing. Is it handled by media manager anyway?
> 
> Oh, I think I see what you're asking. When screen turns off, generally devices
> are going to sleep mode. So this is okay. If we have window focus and we get
an
> onPause/onStop sequence, it means the system is intentionally trying to shut
the
> app off, either through direct user action (back/home button on remote) or
> indirect (user turned the TV off).
> 
> Also note that this CL introduces no behavior change for the case you
describe.

It may change the behavior if opPause/onStop is called on screen off which stops
the app. With this change, it won't stop the app.

[lcwu1, 2015-01-22 01:56:43]

rs lgtm

[gunsch, 2015-01-22 02:00:52]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-01-22 02:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864923003/1

[commit-bot: I haz the power, 2015-01-22 03:15:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-22 03:16:30]

Patchset 1 (id:??) landed as
https://crrev.com/050bed365f613a1227364055ae19b1e4445f963a
Cr-Commit-Position: refs/heads/master@{#312550}