<webview>: Fix WebRequest API crash

<webview>: Fix WebRequest API crash

If two <webview>s have the same embedder process but have different embedder
WebContents, adding a WebRequest API event listener may fail if they happen
to generate the same subevent names. This CL fixes the problem by updating the
WebRequest EventListener's comparator to account for different <webview>s.

BUG=450161
Committed: https://crrev.com/68e36e8974ef47f59eb73c7d4a6eba13b0df1e43
Cr-Commit-Position: refs/heads/master@{#312952}

[Fady Samuel, 2015-01-21 22:09:24]

fsamuel@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2015-01-21 22:31:45]

lgtm with nits.

https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/w...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/w...
extensions/browser/api/web_request/web_request_api.cc:461: int
web_view_instance_id;
why the change?  It looks like webview is more popular than web_view by around a
factor of 3 in the codebase right now...

https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/w...
extensions/browser/api/web_request/web_request_api.cc:467: if (extension_id <
that.extension_id)
instead, do:
if (extension_id != that.extension_id)
  return extension_id < that.extension_id;
if (sub_event_name != that.sub_event_name)
  return sub_event_name < that.sub_event_name;
if (embedder_process...
if (web_view_instance_id...

Saves a few lines and makes it more readable, IMO.

[Fady Samuel, 2015-01-21 23:05:41]

Addressed comments. CQ'ing now! Thanks!

https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/w...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/w...
extensions/browser/api/web_request/web_request_api.cc:461: int
web_view_instance_id;
On 2015/01/21 22:31:45, Devlin wrote:
> why the change?  It looks like webview is more popular than web_view by around
a
> factor of 3 in the codebase right now...

This matches the naming in extensions/browser/guest_view/web_view. A while back,
when I originally wrote this code, we hadn't decided on a convention, sometimes
we used webview and others web_view. We later decided on web_view, so we are
making those changes as we see them.

https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/w...
extensions/browser/api/web_request/web_request_api.cc:467: if (extension_id <
that.extension_id)
On 2015/01/21 22:31:45, Devlin wrote:
> instead, do:
> if (extension_id != that.extension_id)
>   return extension_id < that.extension_id;
> if (sub_event_name != that.sub_event_name)
>   return sub_event_name < that.sub_event_name;
> if (embedder_process...
> if (web_view_instance_id...
> 
> Saves a few lines and makes it more readable, IMO.

Done.

[Fady Samuel, 2015-01-21 23:07:04]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-01-21 23:08:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864893003/40001

[commit-bot: I haz the power, 2015-01-22 00:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 00:58:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2015-01-23 21:43:04]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-01-23 21:44:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864893003/80001

[commit-bot: I haz the power, 2015-01-23 22:42:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-23 22:44:28]

Patchset 5 (id:??) landed as
https://crrev.com/68e36e8974ef47f59eb73c7d4a6eba13b0df1e43
Cr-Commit-Position: refs/heads/master@{#312952}