Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 864893003: <webview>: Fix WebRequest API crash (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview>: Fix WebRequest API crash If two <webview>s have the same embedder process but have different embedder WebContents, adding a WebRequest API event listener may fail if they happen to generate the same subevent names. This CL fixes the problem by updating the WebRequest EventListener's comparator to account for different <webview>s. BUG=450161 Committed: https://crrev.com/68e36e8974ef47f59eb73c7d4a6eba13b0df1e43 Cr-Commit-Position: refs/heads/master@{#312952}

Patch Set 1 #

Patch Set 2 : Remove unnecessary change #

Total comments: 4

Patch Set 3 : Cleanup #

Patch Set 4 : Fixed failing tests #

Patch Set 5 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 3 8 chunks +13 lines, -13 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 2 3 8 chunks +29 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Fady Samuel
5 years, 11 months ago (2015-01-21 22:09:24 UTC) #2
Devlin
lgtm with nits. https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/web_request/web_request_api.cc File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/web_request/web_request_api.cc#newcode461 extensions/browser/api/web_request/web_request_api.cc:461: int web_view_instance_id; why the change? It ...
5 years, 11 months ago (2015-01-21 22:31:45 UTC) #3
Fady Samuel
Addressed comments. CQ'ing now! Thanks! https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/web_request/web_request_api.cc File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/864893003/diff/20001/extensions/browser/api/web_request/web_request_api.cc#newcode461 extensions/browser/api/web_request/web_request_api.cc:461: int web_view_instance_id; On 2015/01/21 ...
5 years, 11 months ago (2015-01-21 23:05:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864893003/40001
5 years, 11 months ago (2015-01-21 23:08:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/16840) Try jobs failed on following ...
5 years, 11 months ago (2015-01-22 00:58:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864893003/80001
5 years, 11 months ago (2015-01-23 21:44:17 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-23 22:42:39 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:44:28 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/68e36e8974ef47f59eb73c7d4a6eba13b0df1e43
Cr-Commit-Position: refs/heads/master@{#312952}

Powered by Google App Engine
This is Rietveld 408576698