Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 864833003: Revert of Make GrScratchKey memory buffer correct size on copy (Closed)

Created:
5 years, 11 months ago by mtklein
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make GrScratchKey memory buffer correct size on copy (patchset #1 id:1 of https://codereview.chromium.org/860333002/) Reason for revert: Our Valgrind bot just spewed out a weird error. I don't know if it's related, but it looks at least like one of the stacks was in the right area, so I'm going to revert this precautionarily. Sorry if this is a false positive. http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/266/steps/dm/logs/stdio Original issue's description: > Make GrScratchKey memory buffer correct size on copy > > Scratch key memory buffer of a copy of a key was too big. The (new) copy > was N times uint32_t bytes instead of N bytes. > > Adds few tests to resource cache. These tests would not catch the too > big buffer. This is just a precaution for too small buffers. The main > idea of the test change is that the scratch key should contain some > information, so that lookup with a scratch key can also return no > match. Otherwise testing of scratch lookup result is not indicative of > correct code (eg. no-information scratch key will always match). > > Committed: https://skia.googlesource.com/skia/+/711ef4831363fb8cbdf061dc2c36c65b13c0ccf2 TBR=bsalomon@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/988018c817f341c0ce09297b7ba5ba60ba76eba9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -139 lines) Patch
M include/gpu/GrResourceKey.h View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 12 chunks +35 lines, -136 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Make GrScratchKey memory buffer correct size on copy
5 years, 11 months ago (2015-01-21 16:04:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864833003/1
5 years, 11 months ago (2015-01-21 16:05:49 UTC) #2
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 16:06:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/988018c817f341c0ce09297b7ba5ba60ba76eba9

Powered by Google App Engine
This is Rietveld 408576698