Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 864833002: Remove the need for asCoeff in SkXfermode. (Closed)

Created:
5 years, 11 months ago by egdaniel
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@moreXferCleanup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove the need for asCoeff in SkXfermode. BUG=skia: Committed: https://skia.googlesource.com/skia/+/dcfb7cf336cafffd8d149c908b615e1deaa3a49b

Patch Set 1 #

Total comments: 1

Patch Set 2 : change 255 to 0xff #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -112 lines) Patch
M include/core/SkXfermode.h View 2 chunks +35 lines, -23 lines 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +1 line, -17 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 1 1 chunk +17 lines, -54 lines 0 comments Download
M src/core/SkXfermode.cpp View 5 chunks +59 lines, -17 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
egdaniel
The main goal of this cl was to remove the need for asCoeff from SkXfermode. ...
5 years, 11 months ago (2015-01-21 16:02:38 UTC) #2
bsalomon
lgtm... I think there is more cleanup that could be done on the signature and ...
5 years, 11 months ago (2015-01-21 17:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864833002/20001
5 years, 11 months ago (2015-01-22 14:39:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1629)
5 years, 11 months ago (2015-01-22 14:40:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864833002/40001
5 years, 11 months ago (2015-01-22 14:44:26 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 14:52:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dcfb7cf336cafffd8d149c908b615e1deaa3a49b

Powered by Google App Engine
This is Rietveld 408576698