Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 86483002: Revert "Revert "remove kA1_Config, as it is no longer supported"" (Closed)

Created:
7 years ago by reed1
Modified:
7 years ago
Reviewers:
rmistry, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Revert "remove kA1_Config, as it is no longer supported"" This reverts commit 36d712f2d4c5c79719280ad95523e6aaa88b068e. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12392

Patch Set 1 #

Patch Set 2 : add change to picture version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -374 lines) Patch
M gm/bitmapcopy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkBitmap.h View 3 chunks +0 lines, -22 lines 0 comments Download
M include/core/SkImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPicture.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M samplecode/SampleFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/animator/SkDrawBitmap.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/core/SkBitmap.cpp View 14 chunks +4 lines, -64 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D src/core/SkBlitter_A1.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/core/SkScalerContext.cpp View 3 chunks +68 lines, -23 lines 0 comments Download
M src/effects/SkTransparentShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 5 chunks +1 line, -55 lines 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 11 chunks +12 lines, -56 lines 0 comments Download
M tests/BitmapGetColorTest.cpp View 2 chunks +0 lines, -63 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
this revert revert includes bumping the picture version # The original CL forgot to do ...
7 years ago (2013-11-25 21:42:37 UTC) #1
reed1
Hmmmm, what do you think about "flattening" a 4-byte tag for 'config', something that is ...
7 years ago (2013-11-25 21:44:44 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-11-26 12:33:40 UTC) #3
rmistry
LGTM
7 years ago (2013-11-26 12:35:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/86483002/20001
7 years ago (2013-11-26 12:37:50 UTC) #5
commit-bot: I haz the power
7 years ago (2013-11-26 12:52:03 UTC) #6
Message was sent while issue was closed.
Change committed as 12392

Powered by Google App Engine
This is Rietveld 408576698