Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 864823003: Revert "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers" (Closed)

Created:
5 years, 11 months ago by teravest
Modified:
5 years, 11 months ago
CC:
gyp-developer_googlegroups.com, scottmg
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Revert "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers" This patch is being reverted because it caused build errors in chromium when attempting a gyp roll. Here's an example error: LINK : fatal error LNK1246: '/SAFESEH' not compatible with 'x64' target machine; link without '/SAFESEH' TBR=sbaig1@bloomberg.net Committed: https://code.google.com/p/gyp/source/detail?r=2027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -43 lines) Patch
M pylib/gyp/MSVSSettings.py View 4 chunks +0 lines, -17 lines 0 comments Download
M pylib/gyp/generator/msvs.py View 5 chunks +1 line, -12 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/win/gyptest-link-safeseh.py View 2 chunks +2 lines, -6 lines 0 comments Download
M test/win/linker-flags/safeseh.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
teravest
5 years, 11 months ago (2015-01-21 17:28:28 UTC) #2
Nico
On 2015/01/21 17:28:28, teravest wrote: Tbr this against the patch author, cc the reviewer (and ...
5 years, 11 months ago (2015-01-21 17:41:03 UTC) #3
teravest
On 2015/01/21 17:41:03, Nico wrote: > On 2015/01/21 17:28:28, teravest wrote: > > Tbr this ...
5 years, 11 months ago (2015-01-21 17:43:03 UTC) #4
teravest
Committed patchset #1 (id:1) manually as 2027 (presubmit successful).
5 years, 11 months ago (2015-01-21 17:45:33 UTC) #6
Shezan Baig (Bloomberg)
5 years, 11 months ago (2015-01-21 18:00:03 UTC) #7
Message was sent while issue was closed.
On 2015/01/21 17:41:03, Nico wrote:
> On 2015/01/21 17:28:28, teravest wrote:
> 
> Tbr this against the patch author, cc the reviewer (and the author, of
course).
> Bonus points for also adding a test that would've caught this problem.


Ack.  Will add a test for x64 targets.

Powered by Google App Engine
This is Rietveld 408576698