test/cctest/test-conversions.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-conversions.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-conversions.cc

diff --git a/test/cctest/test-conversions.cc b/test/cctest/test-conversions.cc

index 93bed7f4de13847880f0eacdcc59ed462675e50f..aa5c2fbcbdd0954c1ea7f30229693edeba9804e8 100644

--- a/test/cctest/test-conversions.cc

+++ b/test/cctest/test-conversions.cc

@@ -172,12 +172,12 @@ TEST(TrailingJunk) {

TEST(NonStrDecimalLiteral) {

UnicodeCache uc;

- CHECK(std::isnan(

- StringToDouble(&uc, " ", NO_FLAGS, v8::base::OS::nan_value())));

- CHECK(

- std::isnan(StringToDouble(&uc, "", NO_FLAGS, v8::base::OS::nan_value())));

- CHECK(std::isnan(

- StringToDouble(&uc, " ", NO_FLAGS, v8::base::OS::nan_value())));

+ CHECK(std::isnan(StringToDouble(&uc, " ", NO_FLAGS,

+ std::numeric_limits<double>::quiet_NaN())));

+ CHECK(std::isnan(StringToDouble(&uc, "", NO_FLAGS,

+ std::numeric_limits<double>::quiet_NaN())));

+ CHECK(std::isnan(StringToDouble(&uc, " ", NO_FLAGS,

+ std::numeric_limits<double>::quiet_NaN())));

CHECK_EQ(0.0, StringToDouble(&uc, "", NO_FLAGS));

CHECK_EQ(0.0, StringToDouble(&uc, " ", NO_FLAGS));

}

« no previous file with comments | « test/cctest/test-code-stubs.cc ('k') | test/cctest/test-double.cc » ('j') | no next file with comments »