src/hydrogen.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 728169d9db6376201c3072be1a3950a717a159f7..9e552a290478e7c96dd63530fc4a2cc830e9b5bf 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -10281,7 +10281,7 @@ HInstruction* HOptimizedGraphBuilder::BuildStringCharCodeAt(

int32_t i = c_index->NumberValueAsInteger32();

Handle<String> s = c_string->StringValue();

if (i < 0 || i >= s->length()) {

- return New<HConstant>(base::OS::nan_value());

+ return New<HConstant>(std::numeric_limits<double>::quiet_NaN());

}

return New<HConstant>(s->Get(i));

}

« no previous file with comments | « src/heap/heap.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »