src/heap/heap.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 79218a32bdd10ee46883cf04081ddc0ede9799ff..641bae04eddff2de9ae2cc61415e3574348e6f1d 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -2911,8 +2911,8 @@ void Heap::CreateInitialObjects() {

set_minus_zero_value(*factory->NewHeapNumber(-0.0, IMMUTABLE, TENURED));

DCHECK(std::signbit(minus_zero_value()->Number()) != 0);

- set_nan_value(

- *factory->NewHeapNumber(base::OS::nan_value(), IMMUTABLE, TENURED));

+ set_nan_value(*factory->NewHeapNumber(

+ std::numeric_limits<double>::quiet_NaN(), IMMUTABLE, TENURED));

set_infinity_value(*factory->NewHeapNumber(V8_INFINITY, IMMUTABLE, TENURED));

// The hole has not been created yet, but we want to put something

« no previous file with comments | « src/compiler/machine-operator-reducer.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »