Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-conversions.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-code-stubs.cc ('k') | test/cctest/test-double.cc » ('j') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-conversions.cc
diff --git a/test/cctest/test-conversions.cc b/test/cctest/test-conversions.cc
index 93bed7f4de13847880f0eacdcc59ed462675e50f..aa5c2fbcbdd0954c1ea7f30229693edeba9804e8 100644
--- a/test/cctest/test-conversions.cc
+++ b/test/cctest/test-conversions.cc
@@ -172,12 +172,12 @@ TEST(TrailingJunk) {
TEST(NonStrDecimalLiteral) {
UnicodeCache uc;
- CHECK(std::isnan(
- StringToDouble(&uc, " ", NO_FLAGS, v8::base::OS::nan_value())));
- CHECK(
- std::isnan(StringToDouble(&uc, "", NO_FLAGS, v8::base::OS::nan_value())));
- CHECK(std::isnan(
- StringToDouble(&uc, " ", NO_FLAGS, v8::base::OS::nan_value())));
+ CHECK(std::isnan(StringToDouble(&uc, " ", NO_FLAGS,
+ std::numeric_limits<double>::quiet_NaN())));
+ CHECK(std::isnan(StringToDouble(&uc, "", NO_FLAGS,
+ std::numeric_limits<double>::quiet_NaN())));
+ CHECK(std::isnan(StringToDouble(&uc, " ", NO_FLAGS,
+ std::numeric_limits<double>::quiet_NaN())));
CHECK_EQ(0.0, StringToDouble(&uc, "", NO_FLAGS));
CHECK_EQ(0.0, StringToDouble(&uc, " ", NO_FLAGS));
}
« no previous file with comments | « test/cctest/test-code-stubs.cc ('k') | test/cctest/test-double.cc » ('j') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698