Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: test/cctest/test-conversions.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-code-stubs.cc ('k') | test/cctest/test-double.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 ALLOW_IMPLICIT_OCTAL | ALLOW_TRAILING_JUNK)); 165 ALLOW_IMPLICIT_OCTAL | ALLOW_TRAILING_JUNK));
166 CHECK_EQ(10.0, StringToDouble(&uc, "10e", 166 CHECK_EQ(10.0, StringToDouble(&uc, "10e",
167 ALLOW_IMPLICIT_OCTAL | ALLOW_TRAILING_JUNK)); 167 ALLOW_IMPLICIT_OCTAL | ALLOW_TRAILING_JUNK));
168 CHECK_EQ(10.0, StringToDouble(&uc, "10e-", 168 CHECK_EQ(10.0, StringToDouble(&uc, "10e-",
169 ALLOW_IMPLICIT_OCTAL | ALLOW_TRAILING_JUNK)); 169 ALLOW_IMPLICIT_OCTAL | ALLOW_TRAILING_JUNK));
170 } 170 }
171 171
172 172
173 TEST(NonStrDecimalLiteral) { 173 TEST(NonStrDecimalLiteral) {
174 UnicodeCache uc; 174 UnicodeCache uc;
175 CHECK(std::isnan( 175 CHECK(std::isnan(StringToDouble(&uc, " ", NO_FLAGS,
176 StringToDouble(&uc, " ", NO_FLAGS, v8::base::OS::nan_value()))); 176 std::numeric_limits<double>::quiet_NaN())));
177 CHECK( 177 CHECK(std::isnan(StringToDouble(&uc, "", NO_FLAGS,
178 std::isnan(StringToDouble(&uc, "", NO_FLAGS, v8::base::OS::nan_value()))); 178 std::numeric_limits<double>::quiet_NaN())));
179 CHECK(std::isnan( 179 CHECK(std::isnan(StringToDouble(&uc, " ", NO_FLAGS,
180 StringToDouble(&uc, " ", NO_FLAGS, v8::base::OS::nan_value()))); 180 std::numeric_limits<double>::quiet_NaN())));
181 CHECK_EQ(0.0, StringToDouble(&uc, "", NO_FLAGS)); 181 CHECK_EQ(0.0, StringToDouble(&uc, "", NO_FLAGS));
182 CHECK_EQ(0.0, StringToDouble(&uc, " ", NO_FLAGS)); 182 CHECK_EQ(0.0, StringToDouble(&uc, " ", NO_FLAGS));
183 } 183 }
184 184
185 185
186 TEST(IntegerStrLiteral) { 186 TEST(IntegerStrLiteral) {
187 UnicodeCache uc; 187 UnicodeCache uc;
188 CHECK_EQ(0.0, StringToDouble(&uc, "0.0", NO_FLAGS)); 188 CHECK_EQ(0.0, StringToDouble(&uc, "0.0", NO_FLAGS));
189 CHECK_EQ(0.0, StringToDouble(&uc, "0", NO_FLAGS)); 189 CHECK_EQ(0.0, StringToDouble(&uc, "0", NO_FLAGS));
190 CHECK_EQ(0.0, StringToDouble(&uc, "00", NO_FLAGS)); 190 CHECK_EQ(0.0, StringToDouble(&uc, "00", NO_FLAGS));
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 // Test most significant bits. 355 // Test most significant bits.
356 x = V8_2PART_UINT64_C(0xE0000000, 00000000); 356 x = V8_2PART_UINT64_C(0xE0000000, 00000000);
357 CHECK(x == UpperBits::encode(7)); 357 CHECK(x == UpperBits::encode(7));
358 CHECK_EQ(7, UpperBits::decode(x)); 358 CHECK_EQ(7, UpperBits::decode(x));
359 359
360 // Test the 32/64-bit boundary bits. 360 // Test the 32/64-bit boundary bits.
361 x = V8_2PART_UINT64_C(0x00000001, 80000000); 361 x = V8_2PART_UINT64_C(0x00000001, 80000000);
362 CHECK(x == MiddleBits::encode(3)); 362 CHECK(x == MiddleBits::encode(3));
363 CHECK_EQ(3, MiddleBits::decode(x)); 363 CHECK_EQ(3, MiddleBits::decode(x));
364 } 364 }
OLDNEW
« no previous file with comments | « test/cctest/test-code-stubs.cc ('k') | test/cctest/test-double.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698