media: Use PlatformVerificationDialog in PermissionContextBase on ChromeOS.

media: Use PlatformVerificationDialog in PermissionContextBase on ChromeOS.

The current infobar/bubble doesn't work well with the text message and help link
for protected media identifier permission request. With this CL, we'll show the
existing platform verification modal UI when using
ProtectedMediaIdentifierPermissionContext on ChromeOS.

When we have an agreement on how to use the current infobar/bubble for protected
media identifier permission request on ChromeOS, we can revert this CL.

BUG=446263
Committed: https://crrev.com/6be45c8c1662ef91fa22bbae645d4acfaa541fe5
Cr-Commit-Position: refs/heads/master@{#314351}

[xhwang, 2015-01-30 23:36:58]

xhwang@chromium.org changed reviewers:
+ bauerb@chromium.org, felt@chromium.org

[xhwang, 2015-01-30 23:36:59]

[See offline email for more details]

felt: PTAL
bauerb: Please OWNERS review.

[xhwang, 2015-01-30 23:37:28]

ericde/ddorwin: FYI

[Bernhard Bauer, 2015-02-02 10:59:40]

https://codereview.chromium.org/864753007/diff/1/chrome/browser/content_setti...
File chrome/browser/content_settings/permission_context_base.cc (right):

https://codereview.chromium.org/864753007/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/permission_context_base.cc:134:
base::Bind(&PermissionContextBase::PermissionDecided,
Do you need to pass this in as a callback? If you know that the callback in
PermissionContextBase::OnPlatformVerificationResult() is always going to be
PermissionContextBase::PermissionDecided(), you could just directly call that
method.

[xhwang, 2015-02-02 21:24:25]

PTAL again. Thanks!

https://codereview.chromium.org/864753007/diff/1/chrome/browser/content_setti...
File chrome/browser/content_settings/permission_context_base.cc (right):

https://codereview.chromium.org/864753007/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/permission_context_base.cc:134:
base::Bind(&PermissionContextBase::PermissionDecided,
On 2015/02/02 10:59:40, Bernhard Bauer wrote:
> Do you need to pass this in as a callback? If you know that the callback in
> PermissionContextBase::OnPlatformVerificationResult() is always going to be
> PermissionContextBase::PermissionDecided(), you could just directly call that
> method.

Done.

[xhwang, 2015-02-03 08:38:02]

Just found that I forgot to upload the new patchset ;)

Now please take a look!

[Bernhard Bauer, 2015-02-03 09:15:46]

lgtm

[xhwang, 2015-02-03 16:35:07]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-02-03 16:36:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864753007/20001

[commit-bot: I haz the power, 2015-02-03 16:39:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-03 16:41:06]

Patchset 2 (id:??) landed as
https://crrev.com/6be45c8c1662ef91fa22bbae645d4acfaa541fe5
Cr-Commit-Position: refs/heads/master@{#314351}