Issue 864753005: Oilpan: restrict implicit RawPtr<U> conversions; U must be T-convertible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 864753005: Oilpan: restrict implicit RawPtr<U> conversions; U must be T-convertible. (Closed)

Created:
5 years, 10 months ago by sof

Modified:
5 years, 10 months ago

Reviewers:
oilpan-reviews, haraken, kouhei (in TOK)

CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: restrict implicit RawPtr<U> conversions; U must be T-convertible. Make RawPtr<U> only be convertible to a RawPtr<T> iff U is type convertible to T. This restricts the range of implicit conversions available, avoiding extts ambiguities. It makes RawPtr symmetric with PassRefPtr in this regard. This fixes Oilpan compilation following r189188. TBR=oilpan-reviews BUG=450662 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189132

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/wtf/RawPtr.h	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864753005/1

5 years, 10 months ago (2015-01-28 19:21:53 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189132

5 years, 10 months ago (2015-01-28 19:22:20 UTC) #4

kouhei (in TOK)

5 years, 10 months ago (2015-01-29 10:51:46 UTC) #6

Message was sent while issue was closed.

On 2015/01/28 23:43:58, haraken wrote:
> LGTM

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages