Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 864753003: Remove implicit uint8_t to char cast in string replace. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove implicit uint8_t to char cast in string replace. R=jkummerow@chromium.org BUG=chromium:446196 LOG=Y Committed: https://crrev.com/f807277b25e4ab3199d515d7e97e210350fac49f Cr-Commit-Position: refs/heads/master@{#26181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 11 months ago (2015-01-21 08:03:40 UTC) #1
Jakob Kummerow
lgtm
5 years, 11 months ago (2015-01-21 08:52:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864753003/1
5 years, 11 months ago (2015-01-21 08:53:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 08:55:09 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 08:55:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f807277b25e4ab3199d515d7e97e210350fac49f
Cr-Commit-Position: refs/heads/master@{#26181}

Powered by Google App Engine
This is Rietveld 408576698