Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 864713004: cc: Trace the viewport size changing. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, jbauman, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Trace the viewport size changing. This will help in tracking down window resize bugs. R=enne, vmpstr BUG=454333 Committed: https://crrev.com/5dba0c6a2a55bfc0387d014c0c17bd9f57d4b9eb Cr-Commit-Position: refs/heads/master@{#314715}

Patch Set 1 #

Total comments: 2

Patch Set 2 : viewporttrace: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
danakj
5 years, 10 months ago (2015-02-05 00:16:00 UTC) #1
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-05 00:22:20 UTC) #2
enne (OOO)
https://codereview.chromium.org/864713004/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/864713004/diff/1/cc/trees/layer_tree_host_impl.cc#newcode2201 cc/trees/layer_tree_host_impl.cc:2201: TRACE_EVENT2("cc", "LayerTreeHostImpl::SetViewportSize", "width", TRACE_EVENT_INSTANT_2?
5 years, 10 months ago (2015-02-05 00:22:25 UTC) #3
danakj
https://codereview.chromium.org/864713004/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/864713004/diff/1/cc/trees/layer_tree_host_impl.cc#newcode2201 cc/trees/layer_tree_host_impl.cc:2201: TRACE_EVENT2("cc", "LayerTreeHostImpl::SetViewportSize", "width", On 2015/02/05 00:22:25, enne wrote: > ...
5 years, 10 months ago (2015-02-05 00:27:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864713004/20001
5 years, 10 months ago (2015-02-05 00:28:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 01:53:05 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 01:54:20 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5dba0c6a2a55bfc0387d014c0c17bd9f57d4b9eb
Cr-Commit-Position: refs/heads/master@{#314715}

Powered by Google App Engine
This is Rietveld 408576698